instructure / canvas-lms

The open LMS by Instructure, Inc.
https://github.com/instructure/canvas-lms/wiki
GNU Affero General Public License v3.0
5.42k stars 2.42k forks source link

About media preview #2271

Closed kenxt closed 8 months ago

kenxt commented 8 months ago

Summary:

we have a self-hosted canvas lms(stable/2023-08-30),I uploaed a mp4 file to context files,when I open the mp4 file, I can't not preview it.

Steps to reproduce:

1.upload mp4 files to context files 2.open the mp4 file 3.can not preview the mp4 file,if it is a picture, you can see preview it

Expected behavior:

always can preview media files

Actual behavior:

can not preview the mp4 file

Additional notes:

noting

Temporary Changes: edit app/views/file_preview/mediapreview.html.erb, according to img Preview.html.erb file: source.txt to: modified.txt

ccutrer commented 8 months ago

Media previews in Canvas rely on an external component - usually Kaltura, or something that is API compatible with Kaltura.

kenxt commented 8 months ago

Media previews in Canvas rely on an external component - usually Kaltura, or something that is API compatible with Kaltura.

Thanks a lot, we have no Kaltura support our canvas, so I think this method can be more friendly