instructure / canvas-lms

The open LMS by Instructure, Inc.
https://github.com/instructure/canvas-lms/wiki
GNU Affero General Public License v3.0
5.4k stars 2.42k forks source link

Stop clobbering bank names when there is more than one question #2347

Open tpaulshippy opened 2 months ago

tpaulshippy commented 2 months ago

Closes https://github.com/instructure/canvas-lms/issues/2346

Test Plan: See replication steps in https://github.com/instructure/canvas-lms/issues/2346

We encountered this issue when trying to import QTI 2.1 items into question banks. It looks like this line of code was questioned at the time it was added (https://github.com/instructure/canvas-lms/commit/a81d6c38526196f5f2b8102ad01015838002dfbb).

When using 1.1.3 QTI files, like the respondus zip at gems/plugins/qti_exporter/spec_canvas/fixtures/canvas_respondus_question_types.zip it looks like the assessment title is pulled from the xml (<assessment title="Title here">) and that is used to name the question bank. This is still a bit deceiving in my opinion, because the UI indicates that you can provide the bank name there (not in the file). But I'm not dealing with those files so I'm not as concerned about that issue.

I just want my question banks to have the name I'm providing.

Before image

After image