search

instructure / canvas-lms

The open LMS by Instructure, Inc.
https://github.com/instructure/canvas-lms/wiki
GNU Affero General Public License v3.0
5.4k stars 2.42k forks source link

Fix margin issue on access code input #2356

Closed ashermyers closed 4 weeks ago

ashermyers commented 1 month ago

Before: image

After: image

Fixes margin issue with input not properly aligning with button on the access code input page.

CLAassistant commented 1 month ago

CLA assistant check
All committers have signed the CLA.

slaughter550 commented 4 weeks ago

@ashermyers ^ was this intentional? We’re currently checking with product to see if this change is desirable

ashermyers commented 4 weeks ago

New PR is here https://github.com/instructure/canvas-lms/pull/2358 (Closed this one by accident)

It seems to not be the intended behavior. All inputs in the design theme have extra margin added to space between other form elements. That's why I submitted the PR is to fix this since this form uses a side-by-side and not a stacked layout like generic form elements.