search

instructure / canvas-lms

The open LMS by Instructure, Inc.
https://github.com/instructure/canvas-lms/wiki
GNU Affero General Public License v3.0
5.4k stars 2.42k forks source link

Fix margin issue on access code input #2358

Closed ashermyers closed 2 weeks ago

ashermyers commented 4 weeks ago

Before: image

After: image

Fixes margin issue with input not properly aligning with button on the access code input page.

ashermyers commented 4 weeks ago

It seems to not be the intended behavior. All inputs in the design theme have extra margin added to space between other form elements. That's why I submitted the PR is to fix this since this form uses a side-by-side and not a stacked layout like generic form elements.

spencerolson commented 2 weeks ago

Thanks for your contribution, @ashermyers ! This has been merged in https://github.com/instructure/canvas-lms/commit/ca74d1c56f0ddd48975092c0e7e035ba77ca428d .