search

instructure / canvas-lms

The open LMS by Instructure, Inc.
https://github.com/instructure/canvas-lms/wiki
GNU Affero General Public License v3.0
5.4k stars 2.42k forks source link

Form Button without SSL leads to browser warning, and wrong url #2363

Open alex-blazh opened 3 weeks ago

alex-blazh commented 3 weeks ago

Summary:

"Update Settings" button doesn't work

Steps to reproduce:

  1. Go "Site Admin/Settings"
  2. press "Update Settings" button

Expected behavior:

form has to have action=https://..... and work

Actual behavior:

Google chrome generate error

The information you’re about to submit is not secure
Because this form is being submitted using a connection that’s not secure, your information will be visible to others.

Additional notes:

branch - prod Canvas itself hidden after google load balancer, which also does ssl termination. For all site and for all internal links everything is working as expected. For for that form we have a problem. If the site code replace

<form id="account_settings" class="account_settings" action="http://canvas.example.org/accounts/site_admin" to <form id="account_settings" class="account_settings" action="https://canvas.example.org/accounts/site_admin" or <form id="account_settings" class="account_settings" action="/accounts/site_admin" everything is working as expected