instructure / canvas-lms

The open LMS by Instructure, Inc.
https://github.com/instructure/canvas-lms/wiki
GNU Affero General Public License v3.0
5.4k stars 2.42k forks source link

Quiz report should use user's preference of CSV #2369

Open Gao-Jun opened 1 week ago

Gao-Jun commented 1 week ago

While generating quiz report, the generated CSV file doesn't use the user's preference of CSV. This patch fix this issue.

Test plan

Expected The exported CSV file should use semicolon(;) as separator

Actual result The exported CSV file still use comma(,) as separator

instructure-sentry-integration[bot] commented 1 week ago

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: app/models/quizzes/quiz_statistics.rb

Function Unhandled Issue
generate_csv InstFS::ServiceError: received code "502" from service, with message " Quizzes::Quiz...
Event Count: 2
generate_csv InstFS::BadRequestError: received code "400" from service, with message ""The service received no request body and has tim... ...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

Gao-Jun commented 1 week ago

How to view the detail of these 'Unhandled Issue'?