instructure / canvas-lms

The open LMS by Instructure, Inc.
https://github.com/instructure/canvas-lms/wiki
GNU Affero General Public License v3.0
5.45k stars 2.44k forks source link

External Tools API documentation is inconsistent #904

Open ToeBee opened 7 years ago

ToeBee commented 7 years ago

The External Tools page in the API documentation does not match the other pages I've seen.

Specifically I am looking for an authoritative definition of what an "External Tool" object looks like. I was expecting it to be linked on the API calls like it is on other pages where it says (for example on the Users page) "Returns a User"

There are examples of response JSON that I can probably use for now but the page doesn't match the rest of the API docs.

ToeBee commented 7 years ago

It looking at this some more today I found the following fields returned in the JSON are not documented anywhere:

I'm pretty sure most of the _menu and _navigation ones are all the same as far as what sub-values are accepted for them but they should probably still be mentioned in the documentation.

ToeBee commented 7 years ago

All of the _navigation elements are documented in the external tool creation call but in reality some tools contain options that are not documented anywhere. I just got one back that looks like this:

"course_navigation":{  
     "custom_fields":{  
        "Domain_URL":"https://k-state.instructure.com/"
     },
     "default":"disabled",
     "enabled":true,
     "selection_height":400,
     "selection_width":800,
     "label":"i\u003EClicker"
}

And that custom_fields object is not mentioned anywhere in the documentation. It is listed as a possible field in the top level external tool object but not inside of the _navigation objects.

ahmadhasankhan commented 6 years ago

True, I am also facing the same issue.

APIs are not documented properly.

Not sure how to these LTI 2.0 APIs. https://canvas.instructure.com/doc/api/file.tools_variable_substitutions.html

stale[bot] commented 4 years ago

Thanks for contributing to this issue. As it has been 2 years since the last activity, we are automatically closing the issue in 30 days. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If that's not the case, please respond before the issue is closed, or post a message on the mailing list. We'll gladly take a look again!

ToeBee commented 4 years ago

I mean... I don't think this has been addressed at all.