instructure / canvas-rce-api

MIT License
20 stars 40 forks source link

is it possible to update the code to bump NodeJS to v14 ? #23

Closed amg-web closed 2 years ago

amg-web commented 3 years ago

is it possible to update the code to bump NodeJS to v14 ?

main code uses NodeJS v14 but rce is still v.12 if both installed on single server without docker it whould be better to update to nodejs 14

amg-web commented 3 years ago

I changed manuall to nodejs 14 Most probebly some dependencies should be updated, as I've got flw warnings with yarn install:

yarn warnings:

`yarn install v1.22.5 info No lockfile found. warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json. [1/5] Validating package.json... [2/5] Resolving packages...

warning express-request-id > node-uuid@1.4.8: Use uuid module instead warning raven > node-uuid@1.4.8: Use uuid module instead warning eslint > file-entry-cache > flat-cache > circular-json@0.3.3: CircularJSON is in maintenance only, flatted is its successor. warning nodemon > chokidar@2.1.8: Chokidar 2 will break on node v14+. Upgrade to chokidar 3 with 15x less dependencies. warning nodemon > chokidar > fsevents@1.2.13: fsevents 1 will break on node v14+ and could be using insecure binaries. Upgrade to fsevents 2. warning nodemon > chokidar > braces > snapdragon > source-map-resolve > resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated warning nodemon > chokidar > braces > snapdragon > source-map-resolve > urix@0.1.0: Please see https://github.com/lydell/urix#deprecated warning sinon > formatio@1.1.1: This package is unmaintained. Use @sinonjs/formatio instead warning sinon > samsam@1.1.2: This package has been deprecated in favour of @sinonjs/samsam warning sinon > formatio > samsam@1.1.3: This package has been deprecated in favour of @sinonjs/samsam [3/5] Fetching packages... info fsevents@2.3.2: The platform "linux" is incompatible with this module. info "fsevents@2.3.2" is an optional dependency and failed compatibility check. Excluding it from installation. info fsevents@1.2.13: The platform "linux" is incompatible with this module. info "fsevents@1.2.13" is an optional dependency and failed compatibility check. Excluding it from installation. [4/5] Linking dependencies... warning " > eslint-plugin-mocha@2.0.0" has incorrect peer dependency "eslint@^2.0.0". warning Workspaces can only be enabled in private projects. [5/5] Building fresh packages... success Saved lockfile. Done in 78.74s.`

npm wanings:

`npm install npm WARN EBADENGINE Unsupported engine { npm WARN EBADENGINE package: 'canvas-rce-api@1.15.0', npm WARN EBADENGINE required: { node: '^14', npm: '^6' }, npm WARN EBADENGINE current: { node: 'v14.16.1', npm: '7.9.0' } npm WARN EBADENGINE }

added 783 packages, and audited 1106 packages in 29s

27 vulnerabilities (10 low, 1 moderate, 15 high, 1 critical)

To address issues that do not require attention, run: npm audit fix

To address all issues (including breaking changes), run: npm audit fix --force `

Results of npm audit fix - npm_audit_fix.txt