instructure / canvas-rce-api

MIT License
19 stars 39 forks source link

ReadMe outdated - JWT secrets moved to vault #62

Open joehobson opened 1 year ago

joehobson commented 1 year ago

A recent commit in Canvas LMS moved the location of the encryption-secret and signing-secret config values from dynamic_settings.yml to vault_contents.yml (in Canvas LMS). The README.md for this repo needs to be updated, but should specify at which release Canvas changed to accommodate users deploying older releases.

Appreciation goes out to Graham Ballantyne for bringing this to our attention on the Canvas LMS users group: https://groups.google.com/u/7/g/canvas-lms-users/c/ydvfmtw2CLE

linnil1 commented 1 year ago

Same issue here. I found that there exists a document somewhere in canvas-lms repo. And it works. https://github.com/instructure/canvas-lms/blob/master/packages/canvas-rce/DEVELOPMENT.md#canvas-rce-api

fchienvuhoang commented 1 year ago

vote this!!!!

adeel-raza commented 1 year ago

+1 The readme should be updated. This is so messed up that a breaking change 3 months ago has not been reflected in the doc. It's not even updated after the issue has been raised on the forum.