instructure / ic-autocomplete

accessible ember autocomplete component
MIT License
57 stars 22 forks source link

[fixed] overzealous autocompletion #16

Open gavacho opened 10 years ago

gavacho commented 10 years ago

This PR changes the component so that it only autocompletes if the matched option starts-with (instead of contains) the user input.

If I start with an empty textbox and type "t", the component autocompletes to "Utah" (the "ah" being highlighted/selected).

This is bad because if the first key press were a typo, a user expects to hit backspace one time and end up with an empty textbox. Instead, the textbox still contains "U".

CLAassistant commented 5 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.