instructure / ic-modal

Ember component for modal dialog
MIT License
62 stars 15 forks source link

Broken with Ember 1.8 beta (and Canary) #19

Open rwjblue opened 10 years ago

rwjblue commented 10 years ago

The way that ic-styled is reading the CSS to inject is broken when running with Ember's Canary branch (which will become 1.8.0-beta.1 in the next day or so).

This will need to be merged https://github.com/instructure/ic-styled/pull/4 and updated in ic-modal's bower.json to fix.


For anyone having issues with this currently, you can use the following in your bower.json to get the version that PR's branch:

    "ic-styled": "rwjblue/ic-styled#fix-for-metal-views"
ryanflorence commented 10 years ago

working on it today, but broccoli loves to unpublish versions and now I'm yak shaving.

ryanflorence commented 10 years ago

closed by 01fc673cd7a409025a630f4b988bf96dad9b55fd thanks @rwjblue

piotrpalek commented 9 years ago

@ryanflorence so this issue could be closed or is something still not working? just wondering :)