search

instructure / ic-tabs

MIT License
64 stars 12 forks source link

Error using ember v1.9.1 #12

Open quaertym opened 9 years ago

quaertym commented 9 years ago

I get the following error when I try to use ic-tabs with ember 1.9.1:

Uncaught Error: Unknown template object: function
samheuck commented 9 years ago

I believe this is an incompatibility with handlebars v2.0.0

Checking the stack trace, this line seems to be incompatible with Ember.Handlebars.template()

exports["default"] = Ember.Handlebars.template(function anonymous(Handlebars,depth0,helpers,partials,data) {

Handlebars is expecting an object, not a function.

samheuck commented 9 years ago

Created a PR that updates dependencies https://github.com/instructure/ic-tabs/pull/13

Main issue is the handlebars template compiler isn't passing an object to Ember.Handlebars.template(). ember-cli-htmlbars works for compiling hbs templates as per https://github.com/toranb/broccoli-ember-hbs-template-compiler/pull/6