search

instructure / ims-lti

A Ruby library to help implement IMS LTI tool consumers and providers
MIT License
200 stars 122 forks source link

Remove the `warn` for unknown parameters in message.rb #152

Open cvoege opened 6 years ago

cvoege commented 6 years ago

The warn on line 124 of /models/messages/message.rb means that any time you create a message with standard LTI parameters (user_id, lis_person_contact_email_primary) it will flood your logs with warnings because they are not in the whitelist. Can we either add all the standard LTI parameters into the whitelist or just remove the warn line?

Ideally there would be an option like "error_on_unknown_paramter" which would make it so it would throw an error in an known paramter, otherwise it just continues.

LucasPiffer commented 5 years ago

Awesome, does not make any sense to warn for fields that are expected by the doc https://www.imsglobal.org/specs/ltiv1p1/implementation-guide