search

instructure / instructure-ui

A UI Component Library made by Instructure, Inc.
https://instructure.design/
Other
439 stars 100 forks source link

refactor(console): remove babel macro #1675

Closed matyasf closed 3 weeks ago

matyasf commented 3 weeks ago

It was only used to insert the #__PURE__ annotation, but it was buggy and it got inserted twice, both in the wrong place (it must be before a function call, we put it before an export statement). https://rollupjs.org/configuration-options/#pure https://webpack.js.org/guides/tree-shaking/#mark-a-function-call-as-side-effect-free

TEST PLAN: Compare the built binaries with the previous version. There should be no differences in other packages. You can do this online here: https://npmdiff.dev/%40instructure%2Fui-tabs/10.2.1/10.2.2-pr-snapshot-1726213252671 (the SNAPSHOT version is from a manual release in this branch https://github.com/instructure/instructure-ui/actions/runs/10845048343 )

github-actions[bot] commented 3 weeks ago

PR Preview Action v1.4.7 :---: :rocket: Deployed preview to https://instructure.github.io/instructure-ui/pr-preview/pr-1675/ on branch gh-pages at 2024-09-13 15:25 UTC