search

instructure / paseto

A paseto implementation in rust.
MIT License
151 stars 14 forks source link

PAE: Borrow arguments #19

Closed vbfox closed 4 years ago

vbfox commented 4 years ago

Motivation

This change avoid having to copy things to pass them to the pae::pae method.

Test Plan

Ran cargo test

Next Steps

⚠ Like #18 this one is a breaking change ⚠

vbfox commented 4 years ago

I don't think I can do that. Either I rebase the branch and PR will contain the other PR commits or I re-create a new PR on my fork for my branch but it won't be a PR here.

AFAIK GitHub allow to change the target of a PR but only to a branch in the repository not another PR or a branch in a fork.

But I would be fine with rebasing when the other PR lands.