search

instructure / paseto

A paseto implementation in rust.
MIT License
151 stars 14 forks source link

Add support for the `time` crate #32

Closed Weasy666 closed 3 years ago

Weasy666 commented 3 years ago

This commit puts chrono behind a feature flag and adds time as an alternative to it.

One thing to note is, that i had to exclude https://github.com/Weasy666/paseto/blob/1b97dcb99565807e43057e96470a03472ed9ac46/src/tokens/mod.rs#L51 from being build, when both features easy_token_chrono and easy_token_time are activated, as there is no way to guess which time crate should be used to parse the json time.

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

Weasy666 commented 3 years ago

Ok...this should again be ready for a review. Hopefully the final one 😅🙃. Sorry for missing all the little things.

Weasy666 commented 3 years ago

You are welcome. And happy to hear that.

frederikbosch commented 3 years ago

Good work on this PR! I am a happy user of the lib and hope a new version can be released. Would that be an option?

Mythra commented 3 years ago

Hey @frederikbosch ,

Yep I'm getting to it, unfortunately have had some other things pop up first. But I'll schedule for some time for it, at the latest I'd expect this weekend.