search

instrumenta / openapi2jsonschema

Convert OpenAPI definitions into JSON schemas for all types in the API
Other
226 stars 87 forks source link

Add header support #29

Open toimela opened 4 years ago

toimela commented 4 years ago

Add support for adding extra headers with '-H' or '--header'. The flag can be specified multiple times to add multiple headers

CsatariGergely commented 4 years ago

@garethr can you please check what else is needed to merge this?

CsatariGergely commented 4 years ago

@brendanjryan , @jburianek , @Sharpie , @evrardjp , @garethr can you please help to figure out what else is needed to merge this pr?

CsatariGergely commented 4 years ago

I am not a maintainer in this, and I haven't tested it, but the code looks good. I would clarify how a user could write the header options, so that they don't have to read the code for it. That could be done by giving an example of the Content-Type and Accept in the readme by showing you're passing those in the command line.

Thanks, I took your names from the head bubles from the right side bar in GitHub.

Maybe pinging @garethr is more effective.

evrardjp commented 3 years ago

Looks okay at first sight. Yeah I am not a maintainer either.