search

instrumentisto / coturn-docker-image

[Closed] Coturn TURN server Docker image
Other
191 stars 47 forks source link

Dockerfile states configuration file is not taken into account by default #18

Closed KoltesDigital closed 4 years ago

KoltesDigital commented 4 years ago

This project's README states that one can use their own config file without changing the command:

  1. You may either specify your own configuration file instead.

    docker run -d --network=host \ -v $(pwd)/my.conf:/etc/coturn/turnserver.conf \ instrumentisto/coturn

However, the CMD puts the -n flag, which disables reading from any config file.

https://github.com/instrumentisto/coturn-docker-image/blob/437c26a508fe23080fcb564eef4a598bf8f6c1b7/Dockerfile#L114

I suspect the flag is here because coturn fails to start if it can't find a config file. If it's the case, I suggest removing the above section from the README. If not, I suggest removing the -n flag.

FTR, I found this issue because I observed my config file was not taken into account. By adding -c /path/to/turnserver.conf it is.

KoltesDigital commented 4 years ago

Thanks!