instrumentisto / medea-jason

Mozilla Public License 2.0
2 stars 2 forks source link

Fix Flutter upgrade to v3.19 #152

Closed evdokimovs closed 9 months ago

evdokimovs commented 9 months ago

Synopsis

The Flutter team has recently released Flutter v3.19, leading to conflicts with certain dependencies of medea-jason on the latest Flutter release. Consequently, the CI is currently broken. This PR resolves these issues.

Solution

Upgrade ffigen dependency version to 11.0.0.

Checklist

tyranron commented 9 months ago

@evdokimovs please, do the same also in medea-flutter-webrtc.

evdokimovs commented 9 months ago

FCM

Fix Flutter upgrade to 3.19 version (#152)

- upgrade `ffigen` Dart package to 11.0.0 version
evdokimovs commented 9 months ago

@tyranron ,

@evdokimovs please, do the same also in medea-flutter-webrtc.

As I see, update to Flutter v3.19 doesn't breaks anything in medea-flutter-webrtc, because it doesn't use flutter_gherkin. It's still better to upgrade ffigen to the newest version even if it's not required, but in case of medea-flutter-webrtc it's better to wait till flutter-rust-bridge will bump version of ffigen on their side before doing it, because otherwise it will break code generation in medea-flutter-webrtc.

I will create PR for this in FRB, so it shouldn't take long.

Also I thinking about adding codegen check job to CI, because sometimes some PR modifies some code related to codegen, but forgets to regenerate Dart code (documentation for example).