instrumentisto / medea-jason

Mozilla Public License 2.0
2 stars 2 forks source link

Fix Control API gRPC gen files unexpected regeneration #168

Closed evdokimovs closed 6 months ago

evdokimovs commented 6 months ago

Synopsis

When working with medea-jason project, sometimes when you run something like cargo check, files related to the Control API gRPC are regenerated. And some files can be deleted and this can be accidentally committed to the branch. This changes are not correct, because this files should live in the git index, but because of the feature flags, they're regenerated incorrectly.

Solution

We can just add server and client features to the default set of features of medea-control-api-proto crate. So when we run cargo check without any arguments, it will compile with this features. This will not remove required files. This fix works, but it needs to be checked, because it can cause some unexpected behaviour.

Checklist

evdokimovs commented 6 months ago
Fix Control API gRPC codegen files unexpected regeneration (#168)
evdokimovs commented 6 months ago

It was fixed in #170