instrumentisto / medea

[Closed] Medea media server
Mozilla Public License 2.0
23 stars 3 forks source link

Fix RpcClient reference leak in Jason (#27) #140

Closed evdokimovs closed 4 years ago

evdokimovs commented 4 years ago

Part of #27

Synopsis

After RpcClientwas refactored to async_trait usage in #135, RpcClient::on_normal_close starts require one more reference to the RpcClient. Because of it, RpcClient remains alive after Room close.

Solution

  1. Return LocalBoxFuture from the RpcClient::on_normal_close instead of async fn usage

  2. Add unit tests for this bug

Checklist

evdokimovs commented 4 years ago

Патч с новыми юнит тестами для проверки того, что они падают на мастере. Применять патч нужно на master ветке.

evdokimovs commented 4 years ago

FCM

Fix RpcClient reference leak in Jason (#140, #27)