Closed fundthmcalculus closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.11%. Comparing base (
2fd3925
) to head (a5b4b19
). Report is 3 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This is a great starting point!
Yes, if you could please try to make use of the X_property
functions that we have it will help clean the code up a bit.
Also don't forget to add some tests! :) we don't have the physical equipment so tests help us to maintain the interface when we're making changes
@scasagrande sorry for the, uh, year-long delay, but the package is updated as you requested. I'll be adding a few other older HP instruments I have in my home lab in the near future, since I have more free time (in between jobs).
no worries! I hope everything is okay 😄
looks like just a bit missing from your test coverage https://app.codecov.io/gh/instrumentkit/InstrumentKit/pull/392/blob/src/instruments/hp/hp3325a.py
looks like just a bit missing from your test coverage https://app.codecov.io/gh/instrumentkit/InstrumentKit/pull/392/blob/src/instruments/hp/hp3325a.py
Thanks for the clarification, fixed! 💪 Now that I know how the layout is supposed to work, I'll be adding a few more HP/Agilent instruments.
fantastic! thank you
bool_property
enum_property
similar to the HP3456A implementation.