instrumentkit / InstrumentKit

Python package for interacting with laboratory equipment over various buses.
250 stars 71 forks source link

feat: Add HP3325A Function Generator #392

Closed fundthmcalculus closed 4 months ago

fundthmcalculus commented 1 year ago
codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.11%. Comparing base (2fd3925) to head (a5b4b19). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #392 +/- ## ======================================= Coverage 99.11% 99.11% ======================================= Files 88 89 +1 Lines 8903 8962 +59 ======================================= + Hits 8824 8883 +59 Misses 79 79 ``` | [Flag](https://app.codecov.io/gh/instrumentkit/InstrumentKit/pull/392/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=instrumentkit) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/instrumentkit/InstrumentKit/pull/392/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=instrumentkit) | `99.11% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=instrumentkit#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

scasagrande commented 1 year ago

This is a great starting point!

Yes, if you could please try to make use of the X_property functions that we have it will help clean the code up a bit.

Also don't forget to add some tests! :) we don't have the physical equipment so tests help us to maintain the interface when we're making changes

fundthmcalculus commented 5 months ago

@scasagrande sorry for the, uh, year-long delay, but the package is updated as you requested. I'll be adding a few other older HP instruments I have in my home lab in the near future, since I have more free time (in between jobs).

scasagrande commented 4 months ago

no worries! I hope everything is okay 😄

scasagrande commented 4 months ago

looks like just a bit missing from your test coverage https://app.codecov.io/gh/instrumentkit/InstrumentKit/pull/392/blob/src/instruments/hp/hp3325a.py

fundthmcalculus commented 4 months ago

looks like just a bit missing from your test coverage https://app.codecov.io/gh/instrumentkit/InstrumentKit/pull/392/blob/src/instruments/hp/hp3325a.py

Thanks for the clarification, fixed! 💪 Now that I know how the layout is supposed to work, I'll be adding a few more HP/Agilent instruments.

scasagrande commented 4 months ago

fantastic! thank you