search

instrumentkit / InstrumentKit

Python package for interacting with laboratory equipment over various buses.
250 stars 71 forks source link

Dressler Cesar 1312 RF generator #426

Closed trappitsch closed 2 weeks ago

trappitsch commented 2 weeks ago

Here's support for the Dressler Cesar 1312 RF generator. An older instrument, but works great via RS232. The most important commands are implemented and especially the package sending/receiving are working very well. Functionality that is covered:

Test coverage included, added to docs.

Curious to hear your opinion @scasagrande. There is no dedicated RF generator, so inheriting from Instruments. Might be something to think about...

scasagrande commented 2 weeks ago

all seems reasonable to me

is the test failure something py38 specific?

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.13%. Comparing base (c406808) to head (aa40c0b). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #426 +/- ## ========================================== + Coverage 98.61% 99.13% +0.51% ========================================== Files 89 90 +1 Lines 8962 9127 +165 ========================================== + Hits 8838 9048 +210 + Misses 124 79 -45 ``` | [Flag](https://app.codecov.io/gh/instrumentkit/InstrumentKit/pull/426/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=instrumentkit) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/instrumentkit/InstrumentKit/pull/426/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=instrumentkit) | `99.13% <100.00%> (+0.51%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=instrumentkit#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

trappitsch commented 2 weeks ago

Was mostly 3.8 specific due to typing issue, plus one issue that failed in 3.9, should be fixed now. 3.8 is EOL, but that's a separate issue ;)