Option to "Pass"/Abstain on voting

insum-labs / conference-manager

Open Source Conference Abstract and Content Selection App

GNU Affero General Public License v3.0

6 stars 5 forks source link

Option to "Pass"/Abstain on voting #20

Closed rimblas closed 5 years ago

rimblas commented 6 years ago

If you "pass" on voting the abstract should be treated as if the user had voted. This is different from voting 0 (not possible today) or 1.

Use the new column ks_session_votes.decline_vote_flag When you vote make sure ks_session_votes.decline_vote_flag becomes null

Should think about ramification on average and reporting.

jwall-insum commented 6 years ago

Changes done and verified on involved reports on the Voting app and Admin app.

Affected Objects:

Voting app and Admin app.
Package ks_session_api
Table ks_session_votes

rimblas commented 6 years ago

@jwall-insum this functionality was simply incomplete.

For example, the decline button was missing so it would never save

We may need one process to register vote and one to delcine the vote. Right now we have a bug when you decline and later try to vote. Both things get registed:

I've made many changes to implement please re-test all scenarios Thanks!

Also, I added a new "Skipped" button on the IR for filtering

rimblas commented 6 years ago

FYI, Voting Stats now counts "Skipped" sessions as voted

jwall-insum commented 6 years ago

Changes: done Different scenarios: tested Affected Objects: voting app