search

int-72h / oftoast2

The New Generation of OFToast.
MIT License
5 stars 2 forks source link

[Request] Dropdown menus for advanced options #12

Open Sloofy opened 1 year ago

Sloofy commented 1 year ago

Summary

Options that are confined to a specific narrow range like number of threads should have a dropdown menu for what you can pick from. This would be helpful in resolving issues like #10 and #13 by preventing inputs that shouldn't be allowed and streamlining the acceptable range clearly. It also doesn't make sense for certain settings to be text fields.

Current behaviour: Screenshot_20230128_085153

Proposed behaviour: Screenshot_20230128_085153

int-72h commented 1 year ago

that's a really good idea

NotQuiteApex commented 1 year ago

I would actually suggest having up or down buttons, since you could easily have more than 4 threads on machines with better CPUs, and it would prevent the need for checking whatever the user inputs.

Right now it seems like toast just assumes you have a max of 4 hyperthreads but it seems like it wouldn't be too hard to have that maximum changed from 4 to whatever OS.get_processor_count() returns.

int-72h commented 1 year ago

It doesn't assume - it uses the old endpoint of /reithreads which was initially for the number of threads but I changed it to be the max no. of threads, as the new endpoint will specify that instead. I'll set it to a higher number for now.

Sloofy commented 1 year ago

Since the acceptable thread count got larger recently, I agree on having up or down buttons instead. I can still see dropdowns working elsewhere in other future options (should they come). I'll just leave this issue up for the time being.