search

int-brain-lab / ibl-neuropixel

Collection of tools to handle Neuropixel 1.0 and 2.0 data
MIT License
11 stars 4 forks source link

Review quality metrics format #26

Closed oliche closed 5 months ago

oliche commented 6 months ago

There are 2 things that would make quality metrics more useful:

  1. make sure that we record thresholdable values in the final dataset, so that the treshold can be readjusted. This is trivial for amplitudes, but for the sliding refractory metric we may want to record the lowest confidence at which a given unit passes
  2. encode the metric result in a integer where each bits encodes whether or not a QC passes or fail. In this case it is easier to have failures set to 1 so that an overall 0 value means all qcs pass, regardless of the number of QCs

Also there is no reason to have this as a separate task. This data should be part of the spike sorter output, especially since the environments are fully compatible.

oliche commented 5 months ago

Addressed in int-brain-lab/ibllib#6d6f547dde320ea5dc4339864c76b2e8d17c6edd