int-brain-lab / mtscomp

Multichannel time series lossless compression in pure Python based on NumPy and zlib
BSD 3-Clause "New" or "Revised" License
34 stars 8 forks source link

Move requirements into setup.py #12

Open fralik opened 2 years ago

fralik commented 2 years ago
fralik commented 2 years ago

OK, can do this. Although, I do not see a real value of a separate requirements file. It is normally used to recreate a development/production environment as a whole, i.e. it would contain pinned version of all libraries (direct dependencies and their subdependencies) installed in an environment. There are tools, like pip-tools, that are able to generate such requirements file from various sources. But since mtscomp may be seen as a library rather than a deployable app, it doesn't make much sense to freeze the environment in a file.

From the code example you provided, why would you want to exclude git+ requirements? Setuptools is able to install those as far as I know.

fralik commented 2 years ago

@oliche , implemented your suggestion about using requirements file.