int128 / terraform-aws-nat-instance

Terraform module to provision a NAT Instance using an Auto Scaling Group and Spot Instance from $1/month
https://registry.terraform.io/modules/int128/nat-instance/aws/
Apache License 2.0
175 stars 90 forks source link

Add ability to add tags #12

Closed dreamrace closed 4 years ago

dreamrace commented 4 years ago

Thank you for this module, it has been an useful tool.

I require the ability to add tags to resources created by this module, so we can keep track of resources in the cost explorer. I added the ability to merge tags passed to the module and individual resource "Name: tag, and created special handling for ASG tags.

Open to comments and corrections!

int128 commented 4 years ago

Thank you for your contribution! Looks good but would you add the variable to README.md?

dreamrace commented 4 years ago

I updated readme, does it look ok to you?

int128 commented 4 years ago

Great! Thank you.