search

int3ro / Nameplates_Threat

Colors the nameplate healthbar according to threat.
GNU General Public License v3.0
1 stars 1 forks source link

Percent hotfix #4

Closed mikfhan closed 6 years ago

mikfhan commented 6 years ago

I forgot to enable the actual percentage gradient updating on each frame rendered. Color on each nameplate should now fade with your difference to highest ally threat.

exochron commented 6 years ago

It looks like there is no more color difference between "I'm tanking" and "my tank buddy is tanking", right? As a tank it helps to visually confirm taunts/tank swaps. That would be a major feature cut (at least for me).

mikfhan commented 6 years ago

Ah, yeah that one got lost in translation; I will keep at it and see if I can't get the blue/magenta offtank colors back in, and see if I can make the orange insecure tanking more visible as well.

mikfhan commented 6 years ago

Thanks both for letting me in 👍 I have deleted my fork and created branch mikfhan off 1.6-release for any future features/tinkering/development I may experiment with (I use SourceTree by the way).

Quick stupid question (I'm a bit new to Git): If you push onto master, should I rebase mikfhan branch off those commits to keep mine up-to-date, or merge master into mikfhan? I would assume rebase since I'm the only one using mikfhan branch, but maybe I'm wrong and still new to Git flow/collaboration.

And if time comes to merge some my changes into master, is that via pull request you two can review and give feedback on first? I'm a bit hesitant of pushing onto master from my side.