search

int3ro / Nameplates_Threat

Colors the nameplate healthbar according to threat.
GNU General Public License v3.0
1 stars 1 forks source link

[Disable] Colors Out of Combat not working #45

Open pupsader1 opened 2 months ago

pupsader1 commented 2 months ago

Hey there, your addon is an essential part of my kit, thanks for making it.

I like to turn off the Colors Out of Combat, because I play hardcore and I'm trained that RED is BAD. So I turn this off, however it is amusingly giving it 3 different colors for the same mob

Screenshot 2024-06-20 182518

Would love to see a fix for this.

Thanks!!

mikfhan commented 2 months ago

I don't want to be the cause of a character wipe! xD I've had some trouble with nameplates not detecting all update events sometimes, can you provoke a color update when you move far enough away so the plate disappears, then move closer again?

It's a pretty resilient bug, something about the end of combat event not triggering always, but gradient updates would suggest otherwise since they run x times every second anyway. More likely the internal tracking of nameplates to mobs somewhere loses a nameplate, or the reset nameplate does not work always, especially if I enable/disable color out of combat then plates dont even change immediately, often I must /reload to force it. Probably a combination of two bugs really.

pupsader1 commented 2 months ago

Thanks for the reply. I am training myself to use the new colors now XD

Here's a couple of clips that can show it better than I can explain, lol. Interesting is that another player can cause the colors to change. The colors are properly set again after a reload, until someone enters combat.

https://github.com/int3ro/Nameplates_Threat/assets/131706585/afe31301-80cc-4354-b244-672df1b7687f

https://github.com/int3ro/Nameplates_Threat/assets/131706585/c68543d1-d6fe-4843-af93-b88de2293e5d

mikfhan commented 1 month ago

Hmm, yeah I remember at one point I had to expand how I detect combat a bit, something about being the healer in a party and others going into melee but I hadn't myself joined combat yet - maybe that logic somehow also runs for friendly players NOT actually in the group xD will have to look into that soon just been some busy weeks this summer sadly, thanks for the clips!

mikfhan commented 1 month ago

I tried to force the red/yellow color reset a bit harder now in 4.3-release :) do reply back if it's still broken.

mikfhan commented 5 days ago

Is this issue still happening in 4.4-release and later? Please reply below or I am tempted to close this old one by 2025 new year.