search

int3ro / Nameplates_Threat

Colors the nameplate healthbar according to threat.
GNU General Public License v3.0
1 stars 1 forks source link

1.8-release candidate 1 #6

Closed mikfhan closed 6 years ago

mikfhan commented 6 years ago

Testing in progress; I have added links to latest curseforge and project pages where players can test the new config panel and report any issues. If none are found and no further code is changed after February 10th I think this candidate 1 should be good enough for 1.8-release.

mikfhan commented 6 years ago

Two players mention they are bombarded with LUA script errors if they install 1.8-release candidate 1 and rename folder to NamePlatesThreat, but I am unable to reproduce this with a blank AddOns folder, regardless of using a new or old character on PTR Brill or EnEU Terrokar realms, and regardless of what AddOn settings I have in the config panel. I also typed /console scripterrors 1 to be sure.

Any help testing this will be greatly appreciated (I have battletag Sjakal#2448 if real-time chat helps); otherwise we may have to assume they installed the AddOn incorrectly or another AddOn is interfering with this latest version somehow, causing errors we cannot reproduce or fix until after 1.8-release.

mikfhan commented 6 years ago

Hah, think I have the explanation now: the addon folder MUST be "NamePlatesThreat" with a capital P, otherwise the GetAddOnMetadata calls will fail to return anything, causing nil reference LUA errors.

So on Feb 10th when merging and creating 1.8-release, make sure the folder name is "NamePlatesThreat". If you cannot rename folders in gitHub/release, just let me know and I may be able to change some code.

mikfhan commented 6 years ago

I have created 1.8-release now, but am unable/unsure how to update CurseForge project and addon pages with a new zip-file. Maybe the description of colors and config panels could also do with an update.

int3ro commented 6 years ago

Hey,

sorry for the inactivity. I'm not actively playing currently and just came back from a long vacation.

Thanks for maintaining the project. If you tell me your username on curseforge.com I'll add you as a project member there aswell. That would allow you to change the project description.

Cheers