Add support of fully qualified domain name (FQDN) in the endpoint url.

intacct / intacct-sdk-js

Official repository of the Sage Intacct SDK for JavaScript in Node.js

https://developer.intacct.com/tools/sdk-node-js/

Apache License 2.0

23 stars 33 forks source link

Add support of fully qualified domain name (FQDN) in the endpoint url. #57

Closed jodem closed 3 years ago

jodem commented 3 years ago

Endpoint only allow the "intacct.com" domain.

It turns out on AWS lambda when we try to use the library, the DNS resolution takes more than 15 seconds. Allowing to use a fully qualified domain name (adding a tailing dot to the domain name) help the DNS resolution and remove the 15 extra second for every api call to intacct.

We updated Endpoint to allow the FQDN and added a related unit test case.

jimmymcpeter commented 3 years ago

It's hard to see but note the trailing . after the .com in the test @jodem added -- https://api.intacct.com./ia/xml/xmlgw.phtml Some info on the trailing dot -- http://www.dns-sd.org/trailingdotsindomainnames.html

NagBoranna commented 3 years ago

Released in v2.1.1