search

intacct / intacct-sdk-php

Official repository of the Sage Intacct SDK for PHP
https://developer.intacct.com/tools/sdk-php/
Apache License 2.0
25 stars 33 forks source link

OnlineClient::executeBatch has an optional parameter that is not checked before it is accessed #168

Closed billypoke closed 2 years ago

billypoke commented 3 years ago

The executeOnlineRequest function checks for the presence of the RequestConfig second parameter and instantiates one if needed.

However, the executeBatch function does not perform this check and if the parameter is not passed, the function will attempt to call isTransaction on null

dylan-holt-sage commented 3 years ago

Hey @billypoke, I took a look at executeBatch and saw that when the RequestConfig isn't there the Transaction field is set to false by default.....

Are you saying that in the event that a someone doesn't set the Transaction field and then that's what should be resolved? Just clarifying.

dylan-holt-sage commented 2 years ago

I have fixed this and it will be going into our 4.0.0 release. Closing this ticket.