search

intake / intake-xarray

Intake plugin for xarray
https://intake-xarray.readthedocs.io/
BSD 2-Clause "Simplified" License
74 stars 36 forks source link

Optionally read EXIF data in ImageSource driver #109

Closed ots22 closed 2 years ago

ots22 commented 2 years ago

This PR adds the ability for the ImageSource driver to read EXIF tags from images.

If exif_tags passed to the constructor is truthy, a Dataset is returned with the image and EXIF tags as data variables (just the ones specified if a list). Otherwise the behaviour is unchanged (a DataArray representing the image is returned).

ImageSource seemed like the best place for this functionality, but would be happy to submit a new PR if it better belongs elsewhere.

Known issue

See the comment below

martindurant commented 2 years ago

Please update fsspec/s3fs in the test envs to get the CI to pass again

ots22 commented 2 years ago

Worth running the CI again to see if the last commit has fixed it? It brings in the upstream CI changes from #111 which looks like it might help.

martindurant commented 2 years ago

running

ots22 commented 2 years ago

Well I guess that wasn't it! Any ideas?

martindurant commented 2 years ago

cf #115

ots22 commented 2 years ago

Anything I can do to help this get merged?

martindurant commented 2 years ago

@aaronspring , this is the same rasterio thing.

I suppose we can merge here anyway.