search

intake / intake-xarray

Intake plugin for xarray
https://intake-xarray.readthedocs.io/
BSD 2-Clause "Simplified" License
74 stars 36 forks source link

rm test_discovery.py #121

Closed raybellwaves closed 2 years ago

raybellwaves commented 2 years ago

Part of the fix for #119

While this is a lazy fix i'll argue this script can be removed.

Firstly, i'm not sure how much of intake/source/discovery.py needs to be tested for a plugin. If I look at another intake plugin I use frequently (https://github.com/intake/intake_geopandas/tree/master/tests) there is no test for intake/source/discovery.py there. If other plugins do test for the this i'd be interested to see how they do it. Secondly, this is a place which is prone to upstream changes in intake. If intake/source/discovery.py changes again this test may have to be modified again which may be a burden for new PRs. Thirdly, it'll speed up my ability to use https://github.com/intake/intake-xarray/pull/118

raybellwaves commented 2 years ago

friendly ping @aaronspring @martindurant

martindurant commented 2 years ago

I agree that this test is not helpful here - any such tests should happen upstream (and there are some there).