intake / intake-xarray

Intake plugin for xarray
https://intake-xarray.readthedocs.io/
BSD 2-Clause "Simplified" License
74 stars 36 forks source link

Remove CI warnings #136

Closed ianthomas23 closed 11 months ago

ianthomas23 commented 12 months ago

Remove warnings in CI:

martindurant commented 11 months ago

We seem to be using dtype=np.float or (assert array.dtype == np.float), should be easy to fix.

ianthomas23 commented 11 months ago

We seem to be using dtype=np.float or (assert array.dtype == np.float), should be easy to fix.

OK, trying that out. Can you approve the CI workflow again please?

martindurant commented 11 months ago

oh, it seems to be rasterio that is doing this too

ianthomas23 commented 11 months ago

@martindurant CI workflow needs approval again.

martindurant commented 11 months ago

There is still one failure there, but I can't immediately tell what the issue is.

ianthomas23 commented 11 months ago

It looks like test_http_server_files is picking up the changes to glob in the latest fsspec release. I think I've fixed this now.

Needs another workflow approval :grin:

ianthomas23 commented 11 months ago

With Python 3.8 we are using older numpy (3.8 support dropped recently) but new rasterio. So we are essentially debugging rasterio-numpy combinations.

martindurant commented 11 months ago

Hm, the failure in py38 would be because the newest numpy no longer builds on that version? We could change the supported versions to 3.9-3.11, seems reasonable.

martindurant commented 11 months ago

Sorry, your comment only just showed up. Let's test 3.9-3.11, but we don't need to change the python_requires as yet (but we could).

ianthomas23 commented 11 months ago

I have pinned rasterio in the python 3.8 environment file and the tests pass locally so let's try that. Can you approve the workflow yet again?

martindurant commented 11 months ago

@ianthomas23 , is it too late to make you a member of Intake :)

ianthomas23 commented 11 months ago

It is too late now, the tests have all passed!