change default values for the combine and concat_dim arguments.

intake / intake-xarray

Intake plugin for xarray

https://intake-xarray.readthedocs.io/

BSD 2-Clause "Simplified" License

76 stars 36 forks source link

change default values for the combine and concat_dim arguments. #69

Closed ghislainp closed 4 years ago

ghislainp commented 4 years ago

They now follow the default fixed by xarray.open_mfdataset.

martindurant commented 4 years ago

Looks pretty good. Can we please have a test with the new default? Also, please can you line-wrap the new docstring, so that it will look ok in a terminal.

martindurant commented 4 years ago

Fixes #65

ghislainp commented 4 years ago

doc changed and added a test for combine='by_coords'

martindurant commented 4 years ago

perfect, thank you.