search

intake / intake-xarray

Intake plugin for xarray
https://intake-xarray.readthedocs.io/
BSD 2-Clause "Simplified" License
74 stars 36 forks source link

fix autodiscover test #79

Closed d70-t closed 4 years ago

d70-t commented 4 years ago

With https://github.com/intake/intake/pull/526, autodiscover can not be imported directly from the intake module anymore.

martindurant commented 4 years ago

This is fine, I can merge it, but it could also be removed since entrypoints are now well-established.

d70-t commented 4 years ago

I've no preference for it and you most likely know the code a lot better than I do. My only goal has been to make the tests pass again. If the best solution is to drop the test, I am fine with it as well. If you like, I can change the PR accordingly.

martindurant commented 4 years ago

I'll merge as is - it can't hurt. If that discover method goes away, we can drop the test then.