intake_geopandas.regionmask

intake / intake_geopandas

An intake plugin for loading datasets with geopandas

BSD 2-Clause "Simplified" License

15 stars 7 forks source link

intake_geopandas.regionmask #22

Closed aaronspring closed 3 years ago

aaronspring commented 3 years ago

[x] use GeoPandasFileSource and allow to pass regionmask_kwargs
[x] test caching
[x] rm self.storage_kwargs

closes #20, #21

aaronspring commented 3 years ago

Looking good @aaronspring, just a small comment on inheritance.

As an aside, I see there are a fair number of no-op formatting changes -- I'd like to add black/flake8 to this repo, but in the meantime, I think it would be best to avoid them as it makes it a bit harder to review.

sorry. used pre-commit locally...

aaronspring commented 3 years ago

just removed self._storage to close #21. should be ready to merge now @ian-r-rose. soon we should also do a black/flake/pre-commit PR

ian-r-rose commented 3 years ago

@aaronspring Yes, would welcome a PR for black/flake8/pre-commit if you are able to work on that.

mathause commented 3 years ago

Cool - could you give an example how this is used?

aaronspring commented 3 years ago

Also I need to register this driver with intake

aaronspring commented 3 years ago

Cool - could you give an example how this is used?

https://gist.github.com/aaronspring/ddf15d7bf9908c1f34b19320bd678fdd