search

intake / intake_geopandas

An intake plugin for loading datasets with geopandas
BSD 2-Clause "Simplified" License
15 stars 7 forks source link

BF caching #23

Closed aaronspring closed 3 years ago

ian-r-rose commented 3 years ago

Hi @aaronspring, what are you trying to accomplish here?

I had deliberately used the more generic open_files, rather than open_local here, since the former doesn't assume that it can be resolved to local (e.g., remote files that aren't cached, in-memory files).

open_local is still used in the shapefile specialization to cover your case of caching a zipfile with multiple shapefiles inside of it.

aaronspring commented 3 years ago

I had a versioning mixup in my environment. I thought the caching in master doesnt work, but apparently I just broke something in my PR. works as expected in master.

So you implemented fsspec objects into geopandas after that was released as 0.8.1, but when I install from master that version is called 0.8.0+xxx. Probably that confused me.