Closed philippjfr closed 4 years ago
Would love the same treatment for dfviz :)
Looks great!
It would be nice to see the "before" pictures to see what's changed.
Personally, I'd vote to update the styling for tables so that the greyed rows are only subtly greyer than the non-grey ones; I think they should be clearly distinct colors but shouldn't come across like a zebra pattern, which is both visually jarring and also makes it more difficult to read black text.
Updated with before/after screenshots.
Debating whether to reverse the decision to fill the whole width of the screen since most of it is empty anyway.
Seems subtle, but I don't spot anything that looks worse!
I'll fix the conflict when I have a spare few minutes.
I don't seem to be able to push here, so made https://github.com/philippjfr/xrviz/pull/1
@martindurant is this in your court?
The PR conflict needs resolution, but I don't seem to be able to push here. @philippjfr ?
I'll fix shortly. Also working on intake integration tonight.
Okay, done.
Excellent. I will be responding only slowly to messages from now for a couple of weeks.
Before:
After:
Before:
After:
Before:
After:
Before:
After:
Before:
After: