intake / xrviz

Interactive visualisation interface for Xarrays
https://xrviz.readthedocs.io
BSD 3-Clause "New" or "Revised" License
105 stars 21 forks source link

Various updates to improve look and feel #34

Closed philippjfr closed 4 years ago

philippjfr commented 4 years ago

Before:

Screen Shot 2019-08-08 at 5 29 25 PM

After:

Screen Shot 2019-08-07 at 7 48 53 PM

Before:

Screen Shot 2019-08-08 at 5 27 45 PM

After:

Screen Shot 2019-08-07 at 7 49 01 PM

Before:

Screen Shot 2019-08-08 at 5 27 53 PM

After:

Screen Shot 2019-08-07 at 7 49 10 PM

Before:

Screen Shot 2019-08-08 at 5 28 01 PM

After:

Screen Shot 2019-08-07 at 7 49 17 PM

Before:

Screen Shot 2019-08-08 at 5 28 08 PM

After:

Screen Shot 2019-08-07 at 7 49 24 PM
martindurant commented 4 years ago

Would love the same treatment for dfviz :)

jbednar commented 4 years ago

Looks great!

It would be nice to see the "before" pictures to see what's changed.

Personally, I'd vote to update the styling for tables so that the greyed rows are only subtly greyer than the non-grey ones; I think they should be clearly distinct colors but shouldn't come across like a zebra pattern, which is both visually jarring and also makes it more difficult to read black text.

philippjfr commented 4 years ago

Updated with before/after screenshots.

philippjfr commented 4 years ago

Debating whether to reverse the decision to fill the whole width of the screen since most of it is empty anyway.

jbednar commented 4 years ago

Seems subtle, but I don't spot anything that looks worse!

martindurant commented 4 years ago

I'll fix the conflict when I have a spare few minutes.

martindurant commented 4 years ago

I don't seem to be able to push here, so made https://github.com/philippjfr/xrviz/pull/1

rsignell-usgs commented 4 years ago

@martindurant is this in your court?

martindurant commented 4 years ago

The PR conflict needs resolution, but I don't seem to be able to push here. @philippjfr ?

philippjfr commented 4 years ago

I'll fix shortly. Also working on intake integration tonight.

philippjfr commented 4 years ago

Okay, done.

martindurant commented 4 years ago

Excellent. I will be responding only slowly to messages from now for a couple of weeks.