Checking "Musicnn" option causes errors and submission to fail

[gingerbeardman]

If I check the "Musicnn" option I get errors:

Request failed with status code 400

After that I see an overlay with:

Uncaught runtime errors:

ERROR undefined is not an object (evaluating 'delete tagobj.tags.genre_musicnn') handleMusicnnCheckboxChange@ callWithErrorHandling@ callWithAsyncErrorHandling@ invoker@

• I have to refresh the page and start again
• I must not check the "Musicnn" option to get results

Thanks for this very useful service!

[intamixx]

Thanks, yes was aware of the vue app issue caused after a 400 (bad request) occurs. I have put in a quick window reload if an error occurs to quickly reload the page and reset the form variables. https://github.com/intamixx/matnn/commit/4f55a372d91ded61c50deab6ebf33af46bf8021b There is a basic html version of the form at https://matnn.intamixx.uk/upload if that suits better.

[gingerbeardman]

My issue was more that every time I select "Musicnn" I get the 400 error. Is that expected?

[intamixx]

I can't recreate the error (i've tried 2 different browsers), is it only happening with that checkbox or the others as well? I get a 400 error as you have shown if I click on the submit button without specifying a file.

[gingerbeardman]

Here's a screen recording

• file specified
• all check marks selected
• browsers
  • Safari 17.5
  • Chrome 126
• macOS 14.5

Chrome

Safari

https://github.com/intamixx/matnn/assets/49612/8bcc1f0e-8803-4f2d-b2a0-25b8f86db929

[intamixx]

Hello, Thanks, I can see the multer field is too long (when everything is checked) as only one model (musicnn or discogs-effnet) can be used when submitting a job for an audiofile.

https://github.com/intamixx/matnn/commit/2ea6626d8515819b62a6bf1bca2e9f4b35a0298f

I've added a check and message for this to prevent both from being checked when the submit button is clicked.

[gingerbeardman]

Oh, right! It would make sense if those two were radio buttons instead of check marks?

[intamixx]

yes that would be better! I wasn't sure if the musicnn model was staying as its not been updated in a few years. its been useful as an alternative model during testing.

[gingerbeardman]

I'm getting more pleasing genres from musicnn in my limited testing

but i'm not wedded to either at this point