search

intbot / ng2-pdfjs-viewer

An angular component for PDFJS and ViewerJS (Supports all versions of angular)
Apache License 2.0
225 stars 113 forks source link

Some content of PDFs not rendering in latest browsers #157

Closed lpuccio closed 2 years ago

lpuccio commented 2 years ago

We're having an issue with some of the text of our documents not rendering on the canvas. It seems that the newest browsers (Chrome 92, Edge) required an update to PDF.js. You may want to update the version of PDF.js that you bundle with the app. Meanwhile, is there a way to get ng2-pdfjs-viewer to use an external version of pdfjs?

Thanks.

The PDFjs issue that was updated is detailed here:

https://github.com/mozilla/pdf.js/issues/13870

szh commented 2 years ago

As you can see here, this is literally a one line fix in pdf.js. I manually editing node_modules\ng2-pdfjs-viewer\pdfjs\build\pdf.worker.js with this change and it fixes it. So maybe in the interim we can just get a patch to that file while we wait on a full update of pdf.js?

codehippie1 commented 2 years ago

For now, manually change it and send in a pull request. I will merge and provide a build. (Please note - I would be doing a pdfjs version bump soon)

Also- If you would like to be part of this project - Let me know, I will add you to the team.

Code

On Fri, Aug 6, 2021, 10:40 AM Shlomo Zalman Heigh @.***> wrote:

As you can see here https://github.com/mozilla/pdf.js/pull/12924/files, this is literally a one line fix in pdf.js. I manually editing node_modules\ng2-pdfjs-viewer\pdfjs\build\pdf.worker.js with this change and it fixes it. So maybe in the interim we can just get a patch to that file while we wait on a full update of pdf.js?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/intbot/ng2-pdfjs-viewer/issues/157#issuecomment-894307604, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEL3UNWDYLMAPFHL5TQJROLT3PX4TANCNFSM5BT4K5HA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

chriseenberg commented 2 years ago

Any news on when the PR will be approved? I need this change also, and cannot edit node_modules as it gets built on a server with a fresh node_modules folder.

codehippie1 commented 1 month ago

The upgrade is underway to v 4.x. This is tracked under enhancement.