search

intbot / ng2-pdfjs-viewer

An angular component for PDFJS and ViewerJS (Supports all versions of angular)
Apache License 2.0
228 stars 113 forks source link

Add support for Angular 15 #197

Closed plaskowski-solwit closed 1 year ago

plaskowski-solwit commented 1 year ago

Hi!

Please update peer deps to support Angular 15 and create new release.

Regards

angelthebault commented 1 year ago

That is to prevent npm from crashing on the command install with the following error :

npm ERR! ERESOLVE unable to resolve dependency tree

A big thank you for the work on this library. Very easy to use and yet so powerfull !

alessandro-vincelli commented 1 year ago

Is this project still alive?

OliverGrack commented 1 year ago

This pull request would update the angular version to 15 https://github.com/intbot/ng2-pdfjs-viewer/pull/204 Not sure if more is needed, since I did not test it yet.

@intbot do you need some help with this repo and testing this merge request? Is this projects still something you want to continue working on, or would you prefer if other people take over and have the ability to merge and publish? In any case tell us how we can help

codehippie1 commented 1 year ago

@OliverGrack @alessandro-vincelli The entire project is upgraded to Angular 15. All PRS are merged. I also had to upgrade SampleApp to test if the upgrade once. Sorry that it took a bit time. I got occupied with other projects and the holidays.

The new package (V 15.0) is available in npm @OliverGrack - Yes, I could certainly use some help. I will add you to the team on github, where you get authority to merge PRs. Sample app can be used for testing with a tar file. I just added a autodeploy.ps1 file to the repo, all it needs is to run, it will spin up Sample app, move through folders as necessary and producing a testing environment with a 'tgz' file.

codehippie1 commented 1 year ago

@OliverGrack Sent an invite.