search

intbot / ng2-pdfjs-viewer

An angular component for PDFJS and ViewerJS (Supports all versions of angular)
Apache License 2.0
224 stars 113 forks source link

Upgrade version pdfjs #248

Open Venera12345 opened 4 months ago

Venera12345 commented 4 months ago

1) is it possible to upgrade the version of the pdf.js library inside your utility? 2) Is this wrapper compatible with later versions of pdf.js 3) Describe the pdf.js build mechanism for embedding in your wrapper

kariudo commented 4 months ago

I've noted some significant rendering issues with specific documents that work in current versions of PDF.js and not in this embedded version. So there are definitly upstream changes this library needs to absorb.

kariudo commented 4 months ago

I needed a version of this designed for the new 4.x+ versions of PDF.js and the default Mozilla viewer, I was going to my a PR here, but the changes ended up very substantial since Mozilla had a lot of breaking changes since this version here, which is likely beyond what the author here wants to accept.

For now you can find my fork here if anyone else is looking for a drop in compatible package to get the current versions of PDF.js and the Mozilla viewer.

https://github.com/kariudo/ng2-pdfjs-viewer published to npm as @kariudo/ng2-pdfjs-viewer

codehippie1 commented 4 months ago

@kariudo I love your effort in going through the pdf.js source (It is hard). Let me look into the fork. Would you like to collaborate on this and get the changes merged eventually?

kariudo commented 4 months ago

@kariudo I love your effort in going through the pdf.js source (It is hard). Let me look into the fork. Would you like to collaborate on this and get the changes merged eventually?

Sure thing, yeah their documentation is unreliable at best and non-existent at worst in most cases, I really did get stuck just rummaging in their source to make things work, particularly in response to changes with the eventbus. I took an axe to a lot of the build process in my branch to simplify things. But take a look at my changes and let me know.

codehippie1 commented 1 month ago

I am on this now. I will share my contact with you directly. If possible, let's hop on a call to discuss the pdfjs 4.x changes

On Wed, Feb 28, 2024, 2:32 PM Hunter Horsman @.***> wrote:

@kariudo https://github.com/kariudo I love your effort in going through the pdf.js source (It is hard). Let me look into the fork. Would you like to collaborate on this and get the changes merged eventually?

Sure thing, yeah their documentation is unreliable at best and non-existent at worst in most cases, I really did get stuck just rummaging in their source to make things work, particularly in response to changes with the eventbus. I took an axe to a lot of the build process in my branch to simplify things. But take a look at my changes and let me know.

— Reply to this email directly, view it on GitHub https://github.com/intbot/ng2-pdfjs-viewer/issues/248#issuecomment-1969702824, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEL3UNWLVDK3H2JDJUQDRI3YV6A5JAVCNFSM6AAAAABDIEQRFWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRZG4YDEOBSGQ . You are receiving this because you commented.Message ID: @.***>

codehippie1 commented 1 month ago

@kariudo I found your email address using a github trick. I will shoot a direct email to you for collaboration.

codehippie1 commented 1 month ago

@kariudo I just went through the changes. Here are my initial thoughts (https://github.com/intbot/ng2-pdfjs-viewer/blob/master/lib/Pdfjs.4.x.upgrade.MD). Let me know your availability via an email reply