search

intbot / ng2-pdfjs-viewer

An angular component for PDFJS and ViewerJS (Supports all versions of angular)
Apache License 2.0
225 stars 113 forks source link

feat: upgrade Angular 18 #252

Closed nicorivat closed 1 month ago

nicorivat commented 1 month ago

Hi,

I updated the library and the SampleApp to Angular 18 :)

Feel free to tell me if there is something else I should do / update !

codehippie1 commented 1 month ago

@nicorivat Thanks, buddy. The diff looks good to me. Merging

nicorivat commented 1 month ago

@codehippie1 Thanks for the merge ;)

Do you think you we will be able to create a release soon ?

codehippie1 commented 1 month ago

Sure. I will do that today or tomorrow

On Mon, Jun 3, 2024, 5:38 AM Nicolas Rivat @.***> wrote:

@codehippie1 https://github.com/codehippie1 Thanks for the merge ;)

Do you think you we will be able to create a release soon ?

— Reply to this email directly, view it on GitHub https://github.com/intbot/ng2-pdfjs-viewer/pull/252#issuecomment-2144741655, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEL3UNXSB4ZZBZZLRQJ56QDZFQ2R3AVCNFSM6AAAAABIQ3GVYOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBUG42DCNRVGU . You are receiving this because you were mentioned.Message ID: @.***>

nicorivat commented 3 weeks ago

@codehippie1 Any news about the release ? :)

codehippie1 commented 3 weeks ago

@nicorivat Published 18.0 just now. Thanks for the reminder.

codehippie1 commented 3 weeks ago

v18.0.0 is tested and published to npm