🚩 PR: Unified action state management

intechstudio / grid-editor

GNU General Public License v3.0

35 stars 3 forks source link

🚩 PR: Unified action state management #756

Closed elsoazemelet closed 4 months ago

elsoazemelet commented 4 months ago

Closes #748

Unified internal state management for config actions (Copy, Paste, etc.). After this PR mismatched states between the Toolbar and Context Menu should not happen.

Example for mismatched states: Overwrite element is enabled in the Context Menu, but not in the Toolbar.

github-actions[bot] commented 4 months ago

Visit the preview URL for this PR (updated for commit 644cf8c):

https://grid-editor-web--pr756-feat-unistatemanagem-4mbguzpx.web.app

_{(expires Wed, 10 Jul 2024 14:53:06 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 2b65ba6ef19c55d367eaffd04e46bcde25305d6f}

narayb commented 4 months ago

In testing, the Discard Element sometimes failed to discard changes on Virtual modules.

Issue could be reproduced by loading the 'Loopy Pro Controller v1.3' Profile on a virtual EN16 and then trying to copy and overwrite encoders. When trying to discard the overwrites, they would remain in all cases active. Only discard all would get rid of these.