🚩 PR: Added block name feature

intechstudio / grid-editor

GNU General Public License v3.0

33 stars 3 forks source link

Closed elsoazemelet closed 1 month ago

elsoazemelet commented 1 month ago

Closes #774

[x] Action blocks can be named when clicked on the edit button on the block header
[x] CodeBlock action block can be renamed when opened in monaco editor

github-actions[bot] commented 1 month ago

Visit the preview URL for this PR (updated for commit 5eccd9c):

_{(expires Mon, 12 Aug 2024 10:56:17 GMT)}

_{Sign: 2b65ba6ef19c55d367eaffd04e46bcde25305d6f}

SukuWc commented 1 month ago

Issues found:

[x] Default config is missing all of the Local variable blocks!
[x] If user chooses same name as the Default was then it should not be added to Lua to save character count
[x] Default Code Block name is show in modal after close and re-open
[x] Adding space to codeblock name (eg: "Test Script") causes is to not be rendered in action list after navigating to different event. It gets parsed into previous action block's last field (see screenshot)

SukuWc commented 1 month ago