Added NRPN MIDI action block

intechstudio / grid-editor

GNU General Public License v3.0

33 stars 3 forks source link

Added NRPN MIDI action block #796

Closed elsoazemelet closed 2 weeks ago

elsoazemelet commented 1 month ago

Closes #734

github-actions[bot] commented 1 month ago

Visit the preview URL for this PR (updated for commit c324fae):

https://grid-editor-web--pr796-feat-nrpn-tdjykxpn.web.app

_{(expires Mon, 02 Sep 2024 11:21:22 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 2b65ba6ef19c55d367eaffd04e46bcde25305d6f}

narayb commented 1 month ago

From a usability standpoint fields for both MSB and LSB parameters are desireable instead of the singular field we have now.

kép

It is also how manufacturers describe NRPN messages received on their devices in their user manuals:

kép

narayb commented 1 month ago

one bug remains: 1, input discrete values into the LSB MSB fields or into the NRPN CC field 2, commit the changes by clicking outside 3, switch to another event or in some other way re-render this block kép 4, '?' will always show up in the NRPN CC field instead of the actual calculated value

narayb commented 4 weeks ago

When writing number into NRPN CC field on a Mac machine, unintended parentheses are rendered. This causes the tests to fail.

kép

Greg-Orca commented 2 weeks ago

NRPN is made for high resolution (14-bit), so it would be more convenient if 14-bit was the default.