intechstudio / profile-cloud

0 stars 0 forks source link

🚩PR: ProfileCloud cleanup #63

Closed elsoazemelet closed 3 months ago

elsoazemelet commented 3 months ago

Closes #62

github-actions[bot] commented 3 months ago

Visit the preview URL for this PR (updated for commit 25a2658):

https://profile-cloud-dev--pr63-prod-improvements-94otpx72.web.app

(expires Mon, 25 Mar 2024 17:14:14 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2a004f867edf1347070dd9beedb18755187a6d4e

elsoazemelet commented 3 months ago
narayb commented 3 months ago

1. Dropdown style search suggestions: Search suggestions are now visible when the search bar is clicked.

Typing in and then deleting a searchword causes massive lag spike when reloading profiles. deletefilter

4. In the Create flow, other parts now disabled until creating a new profile/preset, or until the procedure is canceled.

Entering Create flow locks the sidebar as intended, but doesn't lock interaction on the module, so you can freely change what you're saving, while saving it with just a touch. This can cause unintended elements to become saved. createflowweird

5. After disconnecting a module, the create workflow is still accessable. Error handling is now graceful.

Error message pops up properly when modules are disconnected and trying to save. However, if you reconnect a different module/Page/configuration while the flow is still open, it will save the currently active config, not the one when the user clicked Create. This can lead to unintended content being saved (same issue as point 4.).

All other features tested and are working as intended.

elsoazemelet commented 3 months ago

1. Dropdown style search suggestions: Search suggestions are now visible when the search bar is clicked.

Typing in and then deleting a searchword causes massive lag spike when reloading profiles. deletefilter deletefilter

4. In the Create flow, other parts now disabled until creating a new profile/preset, or until the procedure is canceled.

Entering Create flow locks the sidebar as intended, but doesn't lock interaction on the module, so you can freely change what you're saving, while saving it with just a touch. This can cause unintended elements to become saved. createflowweird createflowweird

5. After disconnecting a module, the create workflow is still accessable. Error handling is now graceful.

Error message pops up properly when modules are disconnected and trying to save. However, if you reconnect a different module/Page/configuration while the flow is still open, it will save the currently active config, not the one when the user clicked Create. This can lead to unintended content being saved (same issue as point 4.).

All other features tested and are working as intended.

Fixed in the latest commit. 4 and 5 is by design, always the selected UI component is saved as preset. Changing PC behaviour to "locking" a selected component would require changing profile/preset saving mechanism.